Repository navigation
Conversation
rich7420
marked this pull request as draft
October 9, 2026 22:38
rich7420
marked this pull request as ready for review
October 10, 2026 05:13
chihsuan
reviewed
Oct 17, 2026
|
|
||
| @Override | ||
| public BucketInfoWithS3Context getS3BucketInfo(String bucketName) throws IOException { | ||
| S3VolumeContext context = getS3VolumeContext(); |
Member
There was a problem hiding this comment.
Should this use getS3VolumeContext(true) like getKeyInfo does? Currently, a missing bucket can return AccessDenied here, but NoSuchBucket in #11479 and in GetObject. Keeping the current order also makes sense to me, but I think we should return a consistent error status.
Contributor
Author
|
Closing in favor of #11479, which also covers MPU initiation and keeps the shared |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
MPU initiation currently resolves the S3 volume context and fetches bucket metadata in separate OM requests. This change returns the bucket metadata and user principal together through InfoBucket, and uses that result in S3 Gateway.
The client gates the combined request on OM version support and retains the existing two-request path for older OMs. Volume and bucket validation, ACL checks, tenant principal mapping, bucket-link resolution, and the expected-owner check retain their existing order and behavior.
What is the link to the Apache JIRA?
https://issues.apache.org/jira/browse/HDDS-16699
How was this patch tested?
TestRpcClient,TestOzoneManagerS3BucketInfo,TestOzoneManagerRequestHandler,TestInitiateMultipartUpload,TestPermissionCheck, andTestMultiTenantVolumefor the combined request, older-OM fallback, errors, ACLs, tenant context, and bucket links.