Repository navigation
HDDS-17072. Allow Jetty HTTPS server to delegate SNI certificate selection for combined keystores. - #11567
Open
ashishkumar50 wants to merge 2 commits into
Open
HDDS-17072. Allow Jetty HTTPS server to delegate SNI certificate selection for combined keystores.#11567ashishkumar50 wants to merge 2 commits into
ashishkumar50 wants to merge 2 commits into
Conversation
…ction for combined keystores.
Contributor
Author
|
@fapifta Please help to review this. |
smengcl
requested changes
Oct 17, 2026
| public static final String OZONE_HTTP_SNI_HOST_CHECK_ENABLED = | ||
| "ozone.http.sni.host.check.enabled"; | ||
| public static final boolean OZONE_HTTP_SNI_HOST_CHECK_ENABLED_DEFAULT = false; | ||
| public static final String OZONE_HTTP_SNI_KEYMANAGER_DELEGATE_ENABLED = |
Contributor
There was a problem hiding this comment.
The new config is missing from ozone-default.xml..
TestOzoneConfigurationFields.testCompareConfigurationClassAgainstXml fails because the class exposes one more key than the XML defaults, so this head cannot pass the configuration consistency check. Please add the key and default to ozone-default.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch makes HttpServer2 install an SNI selector that delegates certificate selection to the underlying key manager, bypassing Jetty's hostname matching. Ozone serves a single identity per port and never relies on per-hostname selection, so this is a no-op for single-cert keystores and restores working TLS for combined ones.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-17072
How was this patch tested?
Unit test