Repository navigation
Conversation
Motivation: PR apache#26739 introduced enableShadowTopics with a false default, disabling existing shadow-topic deployments unless operators explicitly enabled it. Default the new setting to true to preserve the previous behavior. Modifications: - Enable shadow topics by default in ServiceConfiguration and the broker and standalone configuration files. - Cover the default and explicit false override in configuration loading. - Run ShadowTopicTest with the default setting and use a dedicated broker with the setting explicitly disabled in ShadowTopicsDisabledTest. Validation: - All 31 tests in PulsarConfigurationLoaderTest, ShadowTopicTest, and ShadowTopicsDisabledTest passed with retries disabled. - Related Checkstyle checks and git diff --check passed. - Full quickCheck was blocked by an existing missing ASF license header in pulsar-client's generated NasaMission.java. Assisted-by: OpenAI Codex
shibd
approved these changes
Oct 15, 2026
codelipenghui
approved these changes
Oct 15, 2026
codelipenghui
left a comment
Contributor
There was a problem hiding this comment.
LGTM. The change is minimal and correct, and the focused tests pass locally (ShadowTopicTest, ShadowTopicsDisabledTest, PulsarConfigurationLoaderTest; 31/31 with -PtestRetryCount=0).
Two follow-ups:
branch-5.0still hasenableShadowTopics = false, and 5.0.0 shipped with it. Please addrelease/5.0.1as well. Otherwise an upgrade from 4.2.6 or 4.0.15 to 5.0.x disables shadow topics again.- This reverses the default that #26739 shipped in 4.0.14, 4.2.5 and 5.0.0. Please make sure @lhotari agrees, and add a release note (e.g.
release/important-notice) so that users who rely on the disabled default know to setenableShadowTopics=falseexplicitly.
lhotari
requested changes
Oct 15, 2026
lhotari
left a comment
Member
There was a problem hiding this comment.
This is intentionally disabled.
Contributor
|
@lhotari any reason to disable this feature? is there a proposal before? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
PR #26739 introduced enableShadowTopics with a false default, disabling existing shadow-topic deployments unless operators explicitly enabled it. Default the new setting to true to preserve the previous behavior.
Modifications:
Validation:
Assisted-by: OpenAI Codex
Fixes #xyz
Main Issue: #xyz
PIP: #xyz
Motivation
Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If the box was checked, please highlight the changes