Repository navigation
[SYSTEMDS-3855] Vector API: Sparse-Sparse Matrix Multiplication Kernels #2553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Elmanjhg
wants to merge
1
commit into
apache:main
from
Elmanjhg:SYSTEMDS-3855-vector-api-usage-in-dense-sparse-matrix-multiplications
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
src/test/java/org/apache/sysds/test/component/matrix/BenchmarkMatMult.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| package org.apache.sysds.test.component.matrix; | ||
|
|
||
| import java.util.concurrent.TimeUnit; | ||
| import org.apache.sysds.runtime.matrix.data.LibMatrixMult; | ||
| import org.apache.sysds.runtime.matrix.data.MatrixBlock; | ||
| import org.apache.sysds.test.TestUtils; | ||
| import org.openjdk.jmh.annotations.*; | ||
| import org.openjdk.jmh.infra.Blackhole; | ||
| import org.openjdk.jmh.results.format.ResultFormatType; | ||
| import org.openjdk.jmh.runner.Runner; | ||
| import org.openjdk.jmh.runner.RunnerException; | ||
| import org.openjdk.jmh.runner.options.Options; | ||
| import org.openjdk.jmh.runner.options.OptionsBuilder; | ||
|
|
||
| @State(Scope.Thread) | ||
| @BenchmarkMode(Mode.AverageTime) | ||
| @OutputTimeUnit(TimeUnit.MICROSECONDS) | ||
| @Warmup(iterations = 5, time = 1, timeUnit = TimeUnit.SECONDS) | ||
| @Measurement(iterations = 10, time = 1, timeUnit = TimeUnit.SECONDS) | ||
| @Fork(1) | ||
| public class BenchmarkMatMult { | ||
|
|
||
| private MatrixBlock left; | ||
| private MatrixBlock right; | ||
| private MatrixBlock result; | ||
|
|
||
| @Param({"1024", "2048", "4096", "8192"}) | ||
| public int m; | ||
|
|
||
| @Param({"1"}) | ||
| public int cd; | ||
|
|
||
| @Param({"0.5", "0.75", "1.0"}) | ||
| public double sparsityLeft; | ||
|
|
||
| @Param({"0.001", "0.01", "0.1", "0.2"}) | ||
| public double sparsityRight; | ||
|
|
||
| @Param({"1024", "2048", "4096", "8192"}) | ||
| public int n; | ||
|
|
||
| @Setup(Level.Trial) | ||
| public void setup() { | ||
| left = TestUtils.ceil(TestUtils.generateTestMatrixBlock(m, cd, -10, 10, sparsityLeft, 13)); | ||
| if (!left.isInSparseFormat()) { | ||
| left.sparseToDense(); | ||
| left.denseToSparse(true); | ||
| } | ||
|
|
||
| MatrixBlock rightOriginal = TestUtils.ceil(TestUtils.generateTestMatrixBlock(cd, n, -10, 10, sparsityRight, 14)); | ||
| right = new MatrixBlock(); | ||
| right.copy(rightOriginal, false); | ||
| if (!right.isInSparseFormat()) { | ||
| right.sparseToDense(); | ||
| right.denseToSparse(true); | ||
| } | ||
|
|
||
| result = new MatrixBlock(m, n, true); | ||
| result.allocateBlock(); | ||
| } | ||
|
|
||
| @Setup(Level.Iteration) | ||
| public void clearResult() { | ||
| result.reset(m, n, true); | ||
| } | ||
|
|
||
| @Benchmark | ||
| public void benchmarkSparseSparse(Blackhole bh) { | ||
| LibMatrixMult.matrixMult(left, right, result); | ||
| bh.consume(result); | ||
| } | ||
|
|
||
| public static void main(String[] args) throws RunnerException { | ||
| String tag = "vector-api-mult-sparse-sparse-" + System.currentTimeMillis(); | ||
| Options opt = new OptionsBuilder() | ||
| .include(BenchmarkMatMult.class.getName()) | ||
| .jvmArgs("--add-modules=jdk.incubator.vector") | ||
| .result(tag + ".csv") | ||
| .resultFormat(ResultFormatType.CSV) | ||
| .build(); | ||
| new Runner(opt).run(); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not add this JMH dependency to make a benchmark for the matrix multiply.
Instead please move this from being in test to being in performance.
https://github.com/apache/systemds/tree/main/src/test/java/org/apache/sysds/performance
and do not add the dependency package for the benchmark.