Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A published single-platform image such as
polardb-mysql:8.0.2.2.31.1-amd64@sha256:<digest>fails the Helm image check because${image##*:}treats the digest as its tag and looks for multi-platform output. Extract the tag before the digest and after the repository path, while inspecting the complete pinned reference. Existing architecture-tag and dual-architecture requirements remain in place.Validation: five offline regression tests cover 15 scenarios; the old checker fails all four tagged-digest/architecture/registry combinations, and the fixed checker passes all scenarios. Missing images and generic single-platform references still fail. Bash syntax and diff checks pass. A focused GitHub Actions job runs the regression without registry credentials.
This is one prerequisite for apecloud/apecloud-addons#2245. The addon currently pins apecloud-cd v0.1.78; adopting a reviewed release is separate. Its DockerHub matrix also rewrites ACR-only product images to an unpublished repository, which remains unresolved by this change.