ADFA-6346 | Fix app bar flicker on bottom sheet scroll

[jatezzz]

Description

Fixed an issue where the editor's app bar flickered and changed colors (flashing grayish-pink in light mode) when scrolling lists inside the bottom sheet. The app bar was toggling between flat and lifted states. To resolve this, app:liftOnScroll="false" and app:elevation="0dp" were added to the AppBarLayout in both portrait and landscape content_editor.xml layouts to maintain a stable, flat appearance during scroll events.

Details

• Disabled lift-on-scroll behavior in app/src/main/res/layout/content_editor.xml and app/src/main/res/layout-land/content_editor.xml.
• Hardcoded app bar elevation to 0dp.
• Applied spotless reformatting to the modified XML layouts for consistency.

Before

document_5073833325634783310.mp4

After

document_5073833325634783311.mp4

Ticket

ADFA-6346

Observation

The structural layout was also reformatted to ensure consistent indentation and XML tag structure across both portrait and landscape configurations.

[claude]

Claude Code Review

This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.

_{Tip: disable this comment in your organization's Code Review settings.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: 5b7c90b9-2099-4da6-a589-bdfb7441bdf0

📥 Commits

Reviewing files that changed from the base of the PR and between 786dc68 and d935180.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Organization UI
• Review profile: CHILL
• Plan: Essentials
• Run ID: 76f3593e-4246-4cfd-9e86-9c684072e79e

📥 Commits

Reviewing files that changed from the base of the PR and between d90faba and 786dc68.

📒 Files selected for processing (2)

• app/src/main/res/layout-land/content_editor.xml
• app/src/main/res/layout/content_editor.xml

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Summary

• Disable lift-on-scroll and set elevation to 0dp for the editor app bar in portrait and landscape layouts. This is intended to prevent app bar flicker and color changes while scrolling lists in the bottom sheet.
• Risk: The change affects app bar scroll behavior in both orientations. The supplied information does not include test results.

Both editor layouts set the app bar elevation to 0dp and disable lift-on-scroll. The layouts are reformatted, and their view hierarchies remain unchanged.

Changes: Editor Layouts

Layer / File(s)	Summary
App bar attributes app/src/main/res/layout/content_editor.xml, app/src/main/res/layout-land/content_editor.xml	Both layouts set the app bar elevation to 0dp and disable lift-on-scroll. Formatting changes do not alter the view hierarchy.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to 786dc

Both editor layouts disable the elevation and lift changes associated with the flicker while preserving the editor’s scrolling and bottom-sheet behavior. No material merge risk is established.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description check		The description clearly explains the app bar flicker fix, the affected layouts, and the added attributes.
Title check		The title clearly identifies the main change: fixing app bar flicker during bottom sheet scrolling.
Docstring Coverage		No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

_{A rabbit peeks at the editor bar,
Its lift stays still, its height set low.
Two layouts match beneath the moon,
While tidy lines make XML flow.
The rabbit hops and nibbles a tune.}

_{Comment @coderabbitai help to get the list of available commands.}

[Daniel-ADFA]

Approving at 786dc68. No findings survived verification. Checked against the layouts, FullscreenManager, and the Material 1.12.0 AppBarLayout source; not run on a device.

Area	Evidence
Ticket (ADFA-6346)	Sheet scroll: with liftOnScroll off the bar is liftable only through scroll flags, which FullscreenManager clears in windowed mode, so the sheet's scrolls neither lift nor tint it. Light/dark: the same lift tint drove both. Portrait/landscape: both layouts changed; the landscape layout's static flags are cleared the same way, and in fullscreen the bar is collapsed with alpha 0. At rest: an unlifted Material3 bar was already 0dp and its shadow colors are transparent, so pinning 0dp changes nothing.
Style commit	e6d1153 is behavior-neutral: both layouts parse to the same element tree and attributes as stage.
Tests	No automated test; an XML attribute assertion would only restate the layout. Covered by the before/after recordings.
Font scale	N/A: no text, size, or spacing change.
Exceptions, leaks, threading, security, plugins	N/A: layout attributes only.

Not this PR: the Eclipse XML formatter collapses the GPL header into one paragraph, as on 15 files already on stage. That is a Spotless config issue.