Repository navigation
K2GO-455 fix(ui): keep boot gate status bar icons visible in dark theme - #639
Merged
Merged
Conversation
The boot gate is a fixed light "paper" shown in both themes; under edge-to-edge its white surface sits behind the transparent status bar, so dark theme's light icons vanished on it. Force dark status/nav bar icons while the gate owns the screen, and restore the theme default when it lifts.
…/K2GO-455-bootgate-status-bar-contrast
Code review: the status bar was the reported bug, and the white gate does not reach the navigation bar (it keeps its own dark background), so leave the nav bar to the theme instead of driving it app-wide from the status-bar token.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The boot gate is a fixed light "paper" shown in both themes. Under edge-to-edge
its white surface sits behind the transparent status bar, so in dark theme the
light status-bar icons became white-on-white and vanished.
Fix (LibraryActivity): force dark status + navigation bar icons while the boot
gate owns the screen (boot and the shutdown scene), and restore the theme
default (R.bool.k2go_light_system_bars) when the gate lifts.
Verification:
the paper; after the gate lifts, the home restores light icons on the dark
surface.
Notes:
scrim); not introduced by the SDK 36 work (K2GO-454).