Skip to content

test-cnm: Fix dataversion detection #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
reweeden merged 2 commits into from
Oct 16, 2026
Merged

test-cnm: Fix dataversion detection #80

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b133a85
Allow dataversions with multiple digits but no dots
reweeden Sep 28, 2026
6ca9e53
Bump version number
reweeden Sep 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test-cnm/pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ build-backend = "poetry.core.masonry.api"

[project]
name = "test-cnm"
version = "0.10.0"
version = "0.10.1"
description = ""
license = "Apache-2.0"
authors = [
Expand Down
2 changes: 1 addition & 1 deletion test-cnm/test_cnm/tester/collector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@

log = logging.getLogger(__name__)

DATA_VERSION_PATTERN = re.compile(r"^\d+\.\d+|\d$")
DATA_VERSION_PATTERN = re.compile(r"^\d+\.\d+|\d+$")
Comment thread
reweeden marked this conversation as resolved.


class BucketTestCollector:
Expand Down
13 changes: 11 additions & 2 deletions test-cnm/tests/test_cli/test_cmd_list.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,9 @@ def test_bucket(test_bucket):
test_bucket.Object("DATA_VERSION_2/1/PRODUCT_1/file1.txt").put(Body=b"")
test_bucket.Object("DATA_VERSION_2/1/PRODUCT_1/file2.txt").put(Body=b"")

test_bucket.Object("DATA_VERSION_3/003/PRODUCT_1/file1.txt").put(Body=b"")
test_bucket.Object("DATA_VERSION_3/003/PRODUCT_1/file2.txt").put(Body=b"")

test_bucket.Object("OTHER_COLLECTION/PRODUCT_1/file1.txt").put(Body=b"")
test_bucket.Object("OTHER_COLLECTION/PRODUCT_1/file2.txt").put(Body=b"")

Expand All @@ -52,10 +55,12 @@ def test_list_all(capcli):
- DATA_VERSION_1/1.0/PRODUCT_1 (2 files)
DATA_VERSION_2:
- DATA_VERSION_2/1/PRODUCT_1 (2 files)
DATA_VERSION_3:
- DATA_VERSION_3/003/PRODUCT_1 (2 files)
OTHER_COLLECTION:
- OTHER_COLLECTION/PRODUCT_1 (2 files)

Totals: 5 Collections; 6 Tests
Totals: 6 Collections; 7 Tests
""".lstrip("\n")
)

Expand Down Expand Up @@ -122,11 +127,15 @@ def test_list_files(capcli):
- DATA_VERSION_2/1/PRODUCT_1 (2 files)
├── file1.txt
└── file2.txt
DATA_VERSION_3:
- DATA_VERSION_3/003/PRODUCT_1 (2 files)
├── file1.txt
└── file2.txt
OTHER_COLLECTION:
- OTHER_COLLECTION/PRODUCT_1 (2 files)
├── file1.txt
└── file2.txt

Totals: 5 Collections; 6 Tests
Totals: 6 Collections; 7 Tests
""".lstrip("\n")
)
Loading