-
Notifications
You must be signed in to change notification settings - Fork 183
feat(embedded): add /e/authorize email OTP flow #1075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
af824f7
feat : Add support for /e/authorize email OTP flow
pmathew92 3138b09
Made connection mandatory request in the initial request
pmathew92 936c077
Passing default scope to the initial authorize request
pmathew92 25eb279
Minor change in the authorize url creation
pmathew92 4331096
Added the UTs for authorize email OTP flow
pmathew92 dece9c1
Updated the sample app
pmathew92 1f9212a
Added examples.md file
pmathew92 a5bb721
Made index defaults to 0
pmathew92 ee600f5
Made the OtpChannel an enum type
pmathew92 daf9967
Added few more helpers for the error cases
pmathew92 5e41d9a
Addressed few chnages with respect to the updated spec
pmathew92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we are capturing transactionState here. Can we not add authSession in the function signature itself for client to send it. We do send auth session in EmbeddedAuthException right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No . This is intentional. Please re check the design doc. SDK is expected to handle the auth_session within it and not expose it to the calling clients