Repository navigation
style: apply the current Java formatter - #794
Merged
Merged
Conversation
Keep Spotless 3.10.4 while explicitly retaining the established Palantir 2.98.0 formatting rules. The plugin default changed to 2.102.0, which otherwise rewrites existing switch-expression layouts across multiple modules.
This comment has been minimized.
This comment has been minimized.
hln33
reviewed
Oct 14, 2026
zhongkechen
changed the title
This comment has been minimized.
This comment has been minimized.
zhongkechen
force-pushed
the
fix/java-formatter-policy-20261014
branch
from
October 14, 2026 18:33
f2cd1c2 to
beafebf
Compare
zhongkechen
changed the title
This comment has been minimized.
This comment has been minimized.
zhongkechen
changed the title
This comment has been minimized.
This comment has been minimized.
zhongkechen
changed the title
Contributor
Codex AI reviewNo actionable findings. All 14 changed files preserve tokens, literals, and comments; changes are formatting-only. Residual risk: build, formatter, and test checks were not executed during this read-only review. Reviewed commit |
hln33
approved these changes
Oct 14, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotless 3.10.4 defaults to Palantir Java Format 2.102.0, which changes switch-expression layout and makes 14 existing Java files fail the formatting check on main. Apply the formatter's layout to those files so the normal check passes.
The Maven configuration matches main. Formatting rules follow the fixed formatter version supplied by the selected Spotless release.
Validation: the full-reactor
mvn -o -B -ntp spotless:apply spotless:checkpasses on Java 17, andgit diff --checkpasses. All 14 Java changes preserve lexical tokens, string literals, and comments. No runtime tests were rerun for this formatting-only change.