Repository navigation
fix(core): skip plugin hook work without plugins - #781
Merged
Merged
Conversation
This comment has been minimized.
This comment has been minimized.
When a checkpoint response changed an operation's status, on_operation_update converted every operation in the execution for the operation change hook, even when no plugin was registered. The checkpoint loop also copied the whole operation map twice for that hook, and create_checkpoint copied it to read one entry. So the cost of each step grew with the number of operations, and long sequential executions slowed down as they ran. Without a plugin, on_operation_update now returns early, and the checkpoint loop skips the copies and the hook call. create_checkpoint reads only the entry it needs. Plugins receive the same information as before. Fixes #780
yaythomas
force-pushed
the
fix/skip-plugin-hook-without-plugins
branch
from
October 16, 2026 16:42
3ecf944 to
57e5bdb
Compare
Contributor
Codex AI reviewNo actionable findings. The added unit tests cover skipped plugin work and preserved replay detection. Tests were not executed under the read-only review constraints, so runtime and concurrency behavior remain unverified. Reviewed commit |
zhongkechen
approved these changes
Oct 16, 2026
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
When a checkpoint response changed an operation's status, on_operation_update converted every operation in the execution for the operation change hook, even when no plugin was registered. The checkpoint loop also copied the whole operation map twice for that hook, and create_checkpoint copied it to read one entry. So the cost of each step grew with the number of operations, and long sequential executions slowed down as they ran.
Without a plugin, on_operation_update now returns early, and the checkpoint loop skips the copies and the hook call. create_checkpoint reads only the entry it needs. Plugins receive the same information as before.
Issue #, if available:
Fixes #780
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.