Repository navigation
test: test and document incremental buffer short reads with IOU_PBUF_RING_INC - #1655
Open
jdymitarai wants to merge 1 commit into
Open
jdymitarai wants to merge 1 commit into
jdymitarai wants to merge 1 commit into
Conversation
…RING_INC When an incremental buffer ring (IOU_PBUF_RING_INC) is consumed by operations that commit upfront during buffer selection (such as reads on non-pollable regular files), short reads leave unwritten gaps in the buffer because reservation is based on requested length rather than actual transferred bytes. Add test/short_read_inc.c to verify both contiguous pipe reads and regular file behaviors, and document the upfront commitment boundary in the buffer ring man pages. Fixes: axboe#1555
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an incremental buffer ring (IOU_PBUF_RING_INC) is consumed by operations that commit upfront during buffer selection, such as reads on non-pollable regular files, short reads leave unwritten gaps in the buffer because the reservation is based on the requested length rather than actual transferred bytes.
This adds test/short_read_inc.c to verify both contiguous pipe reads and regular file behaviors, wires it into test/Makefile, and clarifies the upfront commitment boundary in the buffer ring man pages.
Fixes #1555