Conversation
Match the documented runbook (make smoke-setup / make smoke-all KEEP_GOING=1) instead of invoking the Python runner directly; make smoke-all already runs forge build, so the separate build step is dropped. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Replace the rpc_url input and repo-wide key secrets with a `network` input that names a GitHub Environment. Each environment holds one SMOKE_CONFIG JSON secret (rpc_url, deployer_pk, user2_pk, optional faucet_*), which is validated, masked, and exported for `make smoke-all`. Runs are serialized per network and the RPC URL is no longer printed in the run summary. No network config lives in git. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
rayyan224
requested review from
amiecorso,
eric-ships and
ilikesymmetry
as code owners
October 2, 2026 16:02
Interface Coverage✅ All interface functions have test coverage. |
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟡 B20FactoryLib.sol | 97.70% | 98.00% | 100.00% | 95.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 99.68% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockPolicyRegistry.sol | 100.00% | 99.58% | 97.78% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 97.12% | 97.50% | 98.21% | 97.03% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
make smoke-setupthenmake smoke-all KEEP_GOING=1(the separateforge buildstep is dropped,smoke-allalready builds).rpc_urlinput and repo-wide key secrets with anetworkinput that names a GitHub Environment. Each environment holds oneSMOKE_CONFIGJSON secret (rpc_url,deployer_pk,user2_pk, optionalfaucet_url/faucet_network), so any chain can be targeted with its own funded keys and nothing network-specific or sensitive lives in git.jq, masks every value before exporting it, and fails fast on a missing/empty secret, invalid JSON, or missing required field (which also catches a mistyped network name).smoke-<network>concurrency group) since they share a deployer nonce; the run summary shows the network name and chain id and no longer prints the RPC URL.script/smoke/README.mddocuments the blob shape and an "Adding a network" recipe.The workflow stays
workflow_dispatchonly and advisory; the harness is unchanged.Test plan
make -n smoke-all KEEP_GOING=1expands to the expected commands.zeronet) with aSMOKE_CONFIGsecret, then dispatch:gh workflow run smoke-tests.yml --ref ci/smoke-use-make-targets -f network=zeronet. Not yet run in Actions.Generated with Claude Code