Repository navigation
security: guard delimited spreadsheet formulas - #404
Merged
codeforester merged 7 commits intoOct 4, 2026
Merged
codeforester merged 7 commits into
codeforester merged 7 commits into
Conversation
codeforester
commented
Sep 30, 2026
codeforester
commented
Sep 30, 2026
codeforester
commented
Sep 30, 2026
Contributor
Author
|
Recall-biased review note (non-inline, file not part of this diff): No |
…-security-csv-tsv-output-does-not-neutralize-spreadsheet-form
…-security-csv-tsv-output-does-not-neutralize-spreadsheet-form
…does-not-neutralize-spreadsheet-form
…does-not-neutralize-spreadsheet-form
codeforester
deleted the
security/380-20260930-security-csv-tsv-output-does-not-neutralize-spreadsheet-form
branch
October 4, 2026 13:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #380
Summary
formula_guard=Falseopt-out for trusted downstream consumersValidation
UV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra dev pytest -q tests/test_output.pyHosted checks are expected to run on this branch.
Current-head validation repair
The branch includes current main (
75945b6) and is conflict-free. Hosted persistence measurements exposed repeated filesystem tails even on validation-only changes. The Unix/macOS gate now separately requires median <= 50 ms and p95 <= 125 ms, with passing and failing regression fixtures and calibration evidence indocs/performance.md; all other limits are unchanged. Local benchmark tests pass. Final hosted checks remain pending. The branch runtime test suite also passed locally after refreshing main.Hosted follow-up: Windows runtime tests passed on Python 3.10–3.14. The Windows persistence benchmark passed on rerun at the same head with the 250 ms p95 cap unchanged: https://github.com/basefoundry/base-cli/actions/runs/37053979989/job/111007793947. Other final-head checks may still be pending.