security: bound and validate discovered project configuration - #419
Conversation
…urrent-invocations-on-an-untim' into security/385-20261003-security-validate-trust-of-ancestor-discovered-project-confi
…urrent-invocations-on-an-untim' into security/385-20261003-security-validate-trust-of-ancestor-discovered-project-confi
…urrent-invocations-on-an-untim' into security/385-20261003-security-validate-trust-of-ancestor-discovered-project-confi
…urrent-invocations-on-an-untim' into security/385-20261003-security-validate-trust-of-ancestor-discovered-project-confi
…urrent-invocations-on-an-untim' into security/385-20261003-security-validate-trust-of-ancestor-discovered-project-confi
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The convenience profile now bounds ancestor discovery, stops at project/filesystem boundaries, and validates discovered configuration permissions and path components before loading. Project environment files receive the same gate. An explicit opt-out supports knowingly shared workspaces; the Windows ACL limitation is documented.
YAML input is capped at 1 MiB and its composed graph is bounded before constructors expand merge aliases. Generic-profile behavior and merge precedence remain unchanged.
Validation: 614 tests and 254 subtests before the alias-construction guard; focused configuration regressions after it; strict typing and repository style. Tests cover unsafe files/directories, explicit opt-out, boundaries, environment files, large inputs, and merge alias expansion.
Train: follows the retention contention fix. Fixes #385.