Repository navigation
Conversation
This fixes compatibility with toolchains that don't ship a libresolv (e.g hermetic_cc_toolchain from Uber). rules_rust currently forces '-lresolv' for a rust stdlib that hasn't needed it for several years. For context, see rust-lang/rust#102766 and bazelbuild#2611 .
dzbarsky
added a commit
to hermeticbuild/rules_rs
that referenced
this pull request
Oct 13, 2026
Remove -lresolv from the macOS stdlib_linkflags in declare_rustc_toolchains. Rust standard libraries no longer need libresolv on macOS, so this allows toolchains without libresolv to link Rust binaries. Keep the existing iOS link flags, matching bazelbuild/rules_rust#4326.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes compatibility with toolchains that don't ship a libresolv (e.g hermetic_cc_toolchain from Uber). rules_rust currently forces '-lresolv' for a rust stdlib that hasn't needed it for several years. For context, see rust-lang/rust#102766 and #2611 .