Document shared HTTP/2 connection lifetime and uploads - #941
Merged
Merged
Conversation
A shared connection has no owner, so a caller's exit resets only its own stream, and it closes itself once idle for the pool timeout. A streaming upload uses its connection on its own until start_response/1, since send_body/2 finds the upload through the connection pid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents the behavior from #939 in the HTTP/2 guide. A shared connection has no single owner: a caller's exit resets only its own stream, and the connection closes itself once it has been idle for the pool
timeout. A streaming upload uses its connection on its own untilstart_response/1, becausesend_body/2finds the upload through the connection pid.