Repository navigation
fix(security): escribir las tres guardas de #725 en la forma que CodeQL modela - #737
Merged
Merged
Conversation
…QL modela La corrida de CodeQL sobre main (5012174) cerró 20 de las 37 alertas de #725 y dejó abiertas 9 js/path-injection y 1 js/prototype-pollution-utility: la contención es real pero el motor no la reconocía como sanitizador. - `resolveLegacyPath`: `path.resolve` + UN `startsWith(root + sep)`, la misma forma que `resolve()` en el mismo fichero (que sí pasa); la condición compuesta `resolved !== root && …` no se modela. El root no es un satélite, nada se pierde. - `InitializeProjectUseCase`: el nombre pasa a una sola variable y, además del regex, se comprueban `includes('..')` y `path.isAbsolute` — los dos guards que TaintedPath modela; el regex solo no cuenta como barrera. - `evolith-config-set`: la comparación literal con `__proto__`/`constructor`/`prototype` se hace sobre el segmento que se escribe (un Set en otra función no se modela); se quita el import sin uso de `sanitizePathInput`. Sin cambio de comportamiento: los mismos 56 tests de los tres sitios siguen verdes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
This was referenced Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seguimiento de #725. La corrida de CodeQL sobre
main(50121746) cerró 20 de 37 alertas; quedaron 9js/path-injectiony 1js/prototype-pollution-utilityporque el motor no reconoce la forma de las guardas, no porque falte contención:resolveLegacyPath:path.resolve+ un solostartsWith(root + sep)— la forma exacta deresolve()en el mismo fichero, que sí pasa. Deja de admitir el propio root como satélite (no lo es).InitializeProjectUseCase: además del regex,includes('..')ypath.isAbsolutesobre una sola variable (los dos guards que TaintedPath modela).evolith-config-set: comparación literal con__proto__/constructor/prototypesobre el segmento escrito; import sin uso fuera (cierra elunused-local-variablenuevo).Sin cambio de comportamiento; 56 tests verdes en los tres sitios,
tsc -blimpio. Las 7 de Scorecard Token-Permissions se cierran en su scan semanal.🤖 Generated with Claude Code