Repository navigation
chore(deps): quitar passport-custom muerto, subir codeql-action en bloque y afinar dependabot - #738
Merged
Conversation
…oque y afinar dependabot Segunda tanda del triaje de PRs de Dependabot (2026-09-19), la que abrió el propio cambio de dependabot.yml de #723: - `passport-custom` estaba declarado en `src/apps/core-api` sin un solo import de passport, passport-custom ni @nestjs/passport en todo `src/`. #728 proponía subirlo; lo correcto es quitarlo. - `github/codeql-action/{init,autobuild,analyze,upload-sarif}` pasan de 4.37.9 a 4.38.0 a la vez (hash b96794f0, el del tag v4.38.0). Dependabot los proponía por separado (#731 analyze, #733 init) y cada PR moría en CodeQL SAST con «Loaded a configuration file for version '4.37.9', but running version '4.38.0'». Se agrupan `github/codeql-action*` en dependabot.yml para que la próxima vez venga en un PR. - `nestjs-pino` 5.x exige Node >= 22.12 y el repo corre en Node 20 por diseño (#727, cerrado); se ignoran sus majors como ya se hace con `@nestjs/*`. - De paso npm normaliza en el lock los rangos que Dependabot escribió con `^` para `yaml` y `@clack/prompts` en workspaces que los fijan exactos. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Contributor
📊 Bilingual Coverage ImpactPR Changes
Repository Coverage
✅ Good: All EN changes have ES counterparts. Generated by GitHub Actions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Qué
Segunda tanda del triaje de PRs de Dependabot (2026-09-19) — la que disparó el cambio de
dependabot.ymlen #723. Se mergearon #730 (yaml patch), #732 (metadata-action v6: solo runtime Node 24), #734 (github-script v9, versión que ya usaban otros 3 workflows) y #735 (build-push-action v7.4, ya probado enci-cd.yml). Este PR recoge lo que quedó de los cinco cerrados:passport-customdesrc/apps/core-api. Dependencia muerta: 0 imports depassport*/@nestjs/passportensrc/. (chore(deps): bump passport-custom from 1.1.1 to 1.2.1 #728 cerrado.)github/codeql-action/*→ 4.38.0 en bloque (init, autobuild, analyze, upload-sarif ×2; hashb96794f0, verificado contra el tagv4.38.0). Por separado, chore(deps): bump github/codeql-action/analyze from 4.37.9 to 4.38.0 #731/chore(deps): bump github/codeql-action/init from 4.37.9 to 4.38.0 #733 morían en CodeQL SAST con «Loaded a configuration file for version '4.37.9', but running version '4.38.0'».dependabot.ymlagrupagithub/codeql-action*para la próxima.dependabot.yml: ignora majors denestjs-pino. 5.x exige Node ≥ 22.12 y el repo corre en Node 20 por diseño (engines >=20 <21,node:20-alpine). (chore(deps): bump nestjs-pino from 4.6.1 to 5.2.0 #727 cerrado.)^que Dependabot escribió en el lock parayamly@clack/prompts(los workspaces fijan exactos).No incluido a propósito: fs-extra 10→11 (#729, cerrado) rompe los binarios del CLI en las 3 plataformas —
fork-ts-checker-webpack-pluginfija^10, npm deja de hoistear y@yao-pkg/pkgno encuentra el módulo. Necesita tocar el empaquetado; queda como pendiente.Verificación
grepde imports passport ensrc/: 0.npm uninstall --package-lock-only; diff = entradas de passport-custom/passport-strategy + normalización de rangos.🤖 Generated with Claude Code