Repository navigation
fix: close Chromium pipe fds when launch is cancelled - #33
Merged
Merged
Conversation
Drop for ChromiumPipeFds closes every end still owned, including the cancellation path that previously returned without close_all. Parent ends transferred into File are disarmed first so they are not closed twice. Co-authored-by: Jared Lunde <jared.lunde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
ChromiumPipeFdsnow closes every pipe end it still owns when it is dropped. Launch cancellation, spawn failure, and the child ends left afterinto_parent_filesall go through thatDrop. Parent ends transferred intoFileare set to-1first so they are not closed twice.Why
Cancelling a Unix pipe-transport launch returned before
into_parent_files, andChromiumPipeFdshad noDrop. Those four descriptors leaked. Repeating cancel-and-retry could exhaust the process file-descriptor limit.Testing
cargo test --locked --lib chromium_pipe_fds -- --test-threads=1(2 passed)cargo check --locked-ksubset fromCONTRIBUTING.mdChecklist