Repository navigation
test: identify closed pipe fds by inode - #34
Merged
Merged
Conversation
F_GETFD after close races with parallel tests, which reuse the lowest freed descriptor. Count /proc/self/fd entries by pipe inode instead. Co-authored-by: Jared Lunde <jared.lunde@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The pipe-fd tests now prove a pipe was closed by counting
/proc/self/fdentries with that pipe's inode.Why
chromium_pipe_fds_drop_closes_every_endfailed onmainbecause it calledF_GETFDon the descriptor number afterclose. Parallel tests reuse the lowest freed number immediately, so descriptor 4 looked open even though this pipe was gone.Testing
cargo test --locked --lib -- --test-threads=16(399 passed, including both pipe-fd tests)cargo check --locked-ksubset fromCONTRIBUTING.mdChecklist