Skip to content
This repository was archived by the owner on Oct 30, 2023. It is now read-only.
This repository was archived by the owner on Oct 30, 2023. It is now read-only.

TRAILING_DELTA missing in FilterType #424

Open

Description

@TheLeBot

Since today 07.04.2022 the API for getting ExchangeInfo produces an exception because Binance added a new FilterType "TRAILING_DELTA" which is not a part of the enum FilterType in current Java-API.
The only way to fix it is to extend FilterType with this value.

Activity

  1. mehc77 commented on Apr 7, 2022

    @mehc77

    It doesn't work adding only that value in the enum..

  2. TheLeBot commented on Apr 7, 2022

    @TheLeBot
    Author

    @mehc77 i only added TRAILING_DELTA to the enum and then it worked for me. Did you do something else except my solution?

  3. mehc77 commented on Apr 7, 2022

    @mehc77

    @TheLeBot i have tried to update the enum in my api and getFilterType keeps giving an error, so I had to skip the search for lot_size to keep it working.
    I'll look into why just adding in the enum doesn't work, I also thought that would suffice..

  4. TheLeBot commented on Apr 10, 2022

    @TheLeBot
    Author

    @mehc77 Which kind of error do you get? I think you better attach the changed class for your program. Probably it does not use your changes somehow. It worked promtely for me as I added TRAILING_DELTA.

  5. selamiwork commented on Apr 13, 2022

    @selamiwork

    Only added TRAILING_DELTA to the enum and then it worked for me. Like the following ;

    public enum FilterType {
    // Symbol
    PRICE_FILTER,
    LOT_SIZE,
    MIN_NOTIONAL,
    MAX_NUM_ORDERS,
    MAX_ALGO_ORDERS,
    MAX_NUM_ALGO_ORDERS,
    ICEBERG_PARTS,
    PERCENT_PRICE,
    MARKET_LOT_SIZE,
    MAX_NUM_ICEBERG_ORDERS,
    MAX_POSITION,
    TRAILING_DELTA,

    // Exchange
    EXCHANGE_MAX_NUM_ORDERS,
    EXCHANGE_MAX_ALGO_ORDERS
    }

  6. GitDani3l commented on Apr 14, 2022

    @GitDani3l

    Only added TRAILING_DELTA to the enum and then it worked for me. Like the following ;

    public enum FilterType { // Symbol PRICE_FILTER, LOT_SIZE, MIN_NOTIONAL, MAX_NUM_ORDERS, MAX_ALGO_ORDERS, MAX_NUM_ALGO_ORDERS, ICEBERG_PARTS, PERCENT_PRICE, MARKET_LOT_SIZE, MAX_NUM_ICEBERG_ORDERS, MAX_POSITION, TRAILING_DELTA,

    // Exchange EXCHANGE_MAX_NUM_ORDERS, EXCHANGE_MAX_ALGO_ORDERS }

    Thank you so much!

  7. meliksah commented on Apr 15, 2022

    @meliksah
  8. TheLeBot commented on May 4, 2022

    @TheLeBot
    Author

    Those using OCO orders should probably have a look at this: https://github.com/binance-exchange/binance-java-api/pull/262/files/0f6856748cce6e011046c10732f5dccaac0352a1..e278acddb9c9cbbd5b7db9c49cb2497de7e35a48

    FilterType for TRAILING_DELTA has some attributes, which should be added into the API declaration!

  9. Eldenayri commented on Jan 18, 2023

    @Eldenayri

    You have to add "PERCENT_PRICE_BY_SIDE" also guys. it's new.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions