Skip to content

Fix zero-byte deserialization iteration and add regression test for z… - #2370

Closed
bl4987637-code wants to merge 1 commit into
bitcoindevkit:masterfrom
bl4987637-code:fix/file-store-zero-progress
Closed

bl4987637-code wants to merge 1 commit into
bitcoindevkit:masterfrom
bl4987637-code:fix/file-store-zero-progress

Conversation

@bl4987637-code

Copy link
Copy Markdown

…ero-sized entries.

Description

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@bl4987637-code
bl4987637-code requested a review from a team as a code owner October 12, 2026 17:30
@github-project-automation github-project-automation Bot moved this to Triage in BDK Chain Oct 12, 2026

@nymius nymius left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate of #2352.

@bl4987637-code

Copy link
Copy Markdown
Author

"Hi @nymius — I opened #2370 but I have not seen that #2352 already contains this fix. I’m happy to close mine and help review/extend #2352 if that’s preferred. Please assign me to any follow-up issue ."

@evanlinjin evanlinjin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Closing as this seems very low-effort and #2352 replaces it.

@evanlinjin evanlinjin closed this Oct 16, 2026
@github-project-automation github-project-automation Bot moved this from Triage to Done in BDK Chain Oct 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants