Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2084.
test_benchmark_blockwiseacceptsdevicewithout parametrizing it, so selecting optimizer benchmarks fails during setup with 27fixture 'device' not founderrors. Parametrize it with the existingget_available_devices()helper and use the same CPU/Windows paged-optimizer skips astest_optimizer32bit.Validation on Windows, Python 3.12.13 and PyTorch 2.14.0+cpu:
python -m pytest tests/test_optim.py -k test_benchmark_blockwise -m benchmark --setup-only -q: reproduced 27 setup errors on main; all 27 cases set up successfully with the patch.TORCHDYNAMO_DISABLE=1, retaining the 500-step loops: 12 passed, 15 skipped. This exercises the 8-bit state path at 4096 elements. Tensor sizes were adjusted by a local pytest collection plugin; the committed benchmark dimensions remain 4096x4096.BNB_TEST_DEVICE=cudasuccessfully resolves the explicit device selection.git diff --checkpass.FreeBSD and accelerator execution were not available locally. Full-size benchmark timings were not measured.