Skip to content

Wire component into shared NATS JetStream transport - #5

Merged
blackboxprogramming merged 2 commits into
mainfrom
codex/nats-ecosystem-20260914
Sep 23, 2026
Merged

blackboxprogramming merged 2 commits into
mainfrom
codex/nats-ecosystem-20260914

Conversation

@blackboxprogramming

@blackboxprogramming blackboxprogramming commented Sep 14, 2026

Copy link
Copy Markdown
Owner

Connects the roadc component to the shared RoadOS NATS notification bus with an opt-in launcher, component manifest, configuration example and ecosystem discovery entries.

Prerequisite RoadOS PR #19 is merged. Integrated this branch with current RoadC main and added launcher contract tests against its merged shared implementation at ce2fff6a42e1e859cd7a2a100eecad13624ec87a. Git cloning RoadOS was unavailable; the dependency snapshot was retrieved through the authenticated connector.

Validation: 343 RoadC tests passed locally with ROAD_TEST_BUS_ROOT selecting that snapshot, plus 20 shared-adapter unit tests. Tests cover offline status without state creation, durable queueing and deduplication, omission of source contents/paths, and disabled network commands. git diff --check passed; published tree matches tested files. Shared-adapter tests require an explicit trusted checkout; default standalone runs skip those four tests.

No live broker delivery was tested in this integration pass. Network remains disabled by default; no service was deployed or relay started. Events contain fingerprints and sizes, and do not authorize execution. Commits use [skip ci]; no hosted CI verification claimed.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-14T05:39:02.581614Z 0f51ef3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Owner Author

Cross-session coordination note (2026-09-16): RoadOS #19 is now merged. While reconciling Road/Roadie companion docs, I confirmed this PR has the same non-sibling install-path issue: NATS.md documents ../RoadOS/requirements-nats.txt even when ROAD_BUS_ROOT is set. Road and Roadie now use:

ROAD_BUS_ROOT="${ROAD_BUS_ROOT:-../RoadOS}"
python3 -m pip install -r "$ROAD_BUS_ROOT/requirements-nats.txt"

I am leaving this branch untouched so the session owning roadc can apply/review the same narrow docs correction without conflicting edits.

Copy link
Copy Markdown
Owner Author

Correction to my coordination note above: use export ROAD_BUS_ROOT="${ROAD_BUS_ROOT:-../RoadOS}", not a non-exported shell assignment. Roadie’s follow-up review caught that the launcher reads os.environ, so export is required for later nats_bus.py processes. I am still leaving this branch untouched for the session owning roadc.

Copy link
Copy Markdown
Owner Author

Final coordination correction: do not export ROAD_BUS_ROOT=../RoadOS for the sibling case. Leave ROAD_BUS_ROOT unset so the launcher keeps its script-relative sibling default. For a non-sibling checkout only, use an explicit absolute path, e.g. export ROAD_BUS_ROOT="/absolute/path/to/RoadOS", then install from $ROAD_BUS_ROOT/requirements-nats.txt. This avoids current-working-directory-dependent failures.

@blackboxprogramming
blackboxprogramming merged commit a736483 into main Sep 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant