Skip to content

refactor: drop the earlier legacyQuiescent option name - #441

Merged
bompus merged 1 commit into
fork/consolidatedfrom
refactor/drop-legacy-quiescent
Oct 11, 2026
Merged

bompus merged 1 commit into
fork/consolidatedfrom
refactor/drop-legacy-quiescent

Conversation

@bompus

@bompus bompus commented Oct 11, 2026 •

Copy link
Copy Markdown
Owner

What

Deletes the legacyQuiescent alias that #438 kept while the installer moved to oldServersStopped. Step 3 of 3.

The installer side landed in bompus/setupLinuxHost#1091 and the installed codegraph-fork-sync was updated to match (its installed files no longer contain the old name; a repeat install changes nothing). The runtime-control test goes back to one case.

Checks

__tests__/runtime-control.test.ts (needs a built dist/): 60 pass locally.

README rows checked

No "About this fork" row or number is affected. The API reference loses its one sentence about the earlier spelling.

Summary by CodeRabbit

  • Behavior Changes
    • Runtime shutdown now skips the writer protocol requirement only when oldServersStopped is enabled. The legacyQuiescent option is no longer supported.
  • Documentation
    • Updated the API reference to remove legacyQuiescent as an alternative option.

The installer that called stopRuntime now passes oldServersStopped, so the
alias kept for the switch-over is removed.
@coderabbitai

coderabbitai Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: bed83f21-38fc-4dd6-8b8e-a70356b445e6


📥 Commits

Reviewing files that changed from the base of the PR and between 14ca664 and 411b67c.



📒 Files selected for processing (3)
  • __tests__/runtime-control.test.ts
  • site/src/content/docs/reference/api.md
  • src/runtime-control.ts


Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.




📝 Walkthrough
📝 Walkthrough

Walkthrough

stopRuntime removes the legacyQuiescent option. It requires the writer protocol unless oldServersStopped is true. The test and API documentation no longer describe legacyQuiescent.

Changes

Runtime stop behavior

Layer / File(s) Summary
Update runtime stop option and behavior
src/runtime-control.ts, __tests__/runtime-control.test.ts, site/src/content/docs/reference/api.md
stopRuntime no longer accepts or checks legacyQuiescent. It skips the writer protocol requirement only when oldServersStopped is true. The test covers that option, and the API documentation removes the earlier-spelling note.


Priority: ⬇️ Low

Merge Risk: ⚪ Minimal · up to 411b6

Legacy daemons remain protected by the writer-protocol check unless oldServersStopped is set. The removed alias has no remaining tracked in-repository references, and no actionable merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 411b6

The change affects 3 systems.

Changed systems: src, site, __tests__

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — src (service) was modified; 1 changed file maps to changed impact.
  • observed — site (service) was modified; 1 changed file maps to changed impact.
  • observed — tests (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in tests/runtime-control.test.ts: The test is no longer parameterized over oldServersStopped and legacyQuiescent; it now describes only the oldServersStopped case.
  • observed — Modified behavior in tests/runtime-control.test.ts: The stop call now sets oldServersStopped: true directly instead of setting the option selected by the removed parameterized case.
  • observed — Modified behavior in site/src/content/docs/reference/api.md: The note identifying {legacyQuiescent: true} as an earlier spelling of {oldServersStopped: true} was removed.
  • observed — Modified behavior in src/runtime-control.ts: stopRuntime removes the legacyQuiescent option from its public options type.


Pre-merge checks | Passed 6
✅ Passed checks (6 passed)
Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Suppressions Explained Passed PASS. The pull request changes only the test, API text, and stopRuntime option handling. The added lines do not add or broaden any lint, type-check, compiler suppression, or ignore directive. The ch…
User-Visible Changes Documented Passed The diff only removes the legacyQuiescent property from the exported stopRuntime API options, its test case, and its API-reference wording. It does not change a CLI command or flag, MCP tool or ar…
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: removing the earlier legacyQuiescent option name.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR



🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR



  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@bompus
bompus merged commit 6a90014 into fork/consolidated Oct 11, 2026
4 checks passed
@bompus
bompus deleted the refactor/drop-legacy-quiescent branch October 11, 2026 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant