Repository navigation
docs(readme): ktor and Exposed index figures for the current fork - #522
Merged
Merged
Conversation
bompus
force-pushed
the
docs/readme-kotlin-after-promotion
branch
from
October 18, 2026 04:04
337745d to
a493f39
Compare
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[Low impact] Updates benchmark figures in the readme. The PR appears safe to merge, with a non-blocking fix needed for the benchmark source reference. Findings
Fix with agent prompt### Issue 1
README.md:202
The new measurement source is still `#PRNUM`, so readers cannot find the benchmark results cited by this sentence. Replace it with a link to PR #522, which contains the measurements and method.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.SummaryUpdates the README's ktor and Exposed figures for the fork at
Reviews (1) · Last reviewed commit: "docs(readme): ktor and Exposed figures f..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A full index of ktor is 26% faster and of JetBrains Exposed 27% faster at fork
5b5ac434than atd161ef74, with 19% and 17% lower peak memory and identical graphs (codegraph init, Node 24, median of 3 alternating runs per build). The README's mid-size paragraph still quoted #515 alone (22% and 19%, measured before #517 and #518 landed), so this updates that sentence.Change
One sentence in README.md "Measured results", in the paragraph on the 2026-10-15 mid-size comparison. It now gives the figures for the fork as it is after #515 (Kotlin companion check), #517 (shared compiled-pattern cache) and #518 (no checkpoints inside the resolution commits). It also says that both corpora still take longer than upstream
e8ec7fd8but now peak lower than it. No code changes.Results
Upstream
e8ec7fd8in the same runs: ktor 7.62 s, 2,636 MiB; Exposed 5.71 s, 2,133 MiB. Upstream's graphs differ from the fork's, as in the mid-size comparison.The floor is the spread (max - min) over six runs of two identical copies of the
5b5ac434build. A change counts only when the medians differ by more than the floor and the two ranges do not overlap; every row above meets that. Graph hashes were identical across d161ef7 and 5b5ac43 on all 18 fork runs (ktor57e9c5136b5e, Exposedb332758c901b). The run used 24 accepted runs, with none rejected, on a 16-vCPU WSL2 host. Each run was asystemd-runscope capped at 16 GiB, at normal priority. A run was admitted only with load under 2 and no swap.Checks
npx vitest run __tests__/readme-sync.test.tsona493f393: 6 of 6 passed, exit 0. The chart of these rows is not attached; the table carries every figure.npm run eval:precision -- <corpus>on all 11 pinned corpora at5b5ac434(vite, vitest, svelte, flask, gin, petclinic, exposed, javalin, slim, jq, json): every case held, each exit 0. It had not run since perf(kernel): indexing a Kotlin project uses less memory #517, perf(index): a fresh mid-size index stops syncing the database inside its resolution commits #518, perf(js): indexing a JavaScript or TypeScript project is faster #519 and the upstream merge in merge: reconcile upstream through baf19067 #520.README rows checked
docs/benchmarks/file quotes the ktor or Exposed figures.Not covered: the full-index and sync tables compare fork
ba972275with upstream3f714bcc(2026-10-14, Node and Bun). Refreshing them for the current fork needs that whole benchmark re-run, with an upstream build. Bun was not measured here.Summary by cubic
Updates the README's mid-size benchmark paragraph with figures for the current fork. The previous sentence quoted only #515; after #517 and #518, the fork at
5b5ac434indexes ktor 26% faster and Exposed 27% faster thand161ef74, with 19% and 17% lower peak memory and identical graphs. The paragraph also notes the fork still takes longer than upstream but now peaks below it.Written for commit 337745d. Summary will update on new commits.