Repository navigation
docs: note that the README's Alamofire row predates the resolver pool change - #525
Merged
Merged
Conversation
… change The row is from the 2026-10-14 run (fork ba97227). After the pool started part-way through on mid-size projects, the 2026-10-15 comparison has the fork at 1.44 s and 1,042 MiB against upstream's 1.38 s and 791 MiB, and a three-run check of the current build took 1.31 to 1.61 s at 919 to 930 MiB.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[Low impact] The documentation change appears safe to merge. SummaryThe README marks the Alamofire row as historical and adds later measurements.
Reviews (1) · Last reviewed commit: "docs: note that the README's Alamofire r..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The README no longer presents the 2026-10-14 Alamofire row (1.90 s, 668 MiB) as the fork's current result.
Why
That row predates the resolver pool change (#506), which starts the pool part-way through on mid-size projects. Afterwards the fork's Alamofire index peaks about 925 MiB, not 668, and the mid-size comparison found no clear wall-time difference from upstream:
ba972275f405d86bvs upstreamc71a3d03559cc097Change
README rows checked
Alamofire row and bullet: changed as above. gin, pretix, CPython, discourse, supabase and n8n rows: not re-measured since #506/#518 (the 2A check found no clear change for pretix and supabase), so left unedited and unmarked.
Checks
On head:
readme-sync6 passed;check:agent-docsexit 0.Summary by cubic
Updates the README's Alamofire benchmark so the 2026-10-14 figure is no longer presented as the fork's current result. That run predates the resolver pool change (#506); the README now adds a note with the two later results and clarifies the later wall-time comparison found no clear difference.
Written for commit c23eeb8. Summary will update on new commits.