Skip to content

docs: note that the README's Alamofire row predates the resolver pool change - #525

Merged
bompus merged 1 commit into
fork/consolidatedfrom
docs/readme-alamofire-figures
Oct 18, 2026
Merged

bompus merged 1 commit into
fork/consolidatedfrom
docs/readme-alamofire-figures

Conversation

@bompus

@bompus bompus commented Oct 18, 2026 •

Copy link
Copy Markdown
Owner

The README no longer presents the 2026-10-14 Alamofire row (1.90 s, 668 MiB) as the fork's current result.

Why

That row predates the resolver pool change (#506), which starts the pool part-way through on mid-size projects. Afterwards the fork's Alamofire index peaks about 925 MiB, not 668, and the mid-size comparison found no clear wall-time difference from upstream:

Source Build Alamofire full index
README row, 2026-10-14 run fork ba972275 1.90 s, 668 MiB
2026-10-15 mid-size comparison, three runs per engine fork f405d86b vs upstream c71a3d03 fork 1.44 s, 1,042 MiB; upstream 1.38 s (no clear change), 791 MiB (+31.7%)
Fresh check, three runs, Node 24, no upstream run, load 1.55-1.82 deployed 559cc097 1.31-1.61 s, 919-930 MiB

Change

  • A note under the full-index table says the Alamofire row predates the change and gives the two later results.
  • The "Slower to index some projects" bullet names the 2026-10-14 run for the Alamofire +12% and says the later comparison found no clear wall-time difference.
  • The 2026-10-14 chart, its 74-comparison tally and the benchmark doc are left as they are: they describe that run.

README rows checked

Alamofire row and bullet: changed as above. gin, pretix, CPython, discourse, supabase and n8n rows: not re-measured since #506/#518 (the 2A check found no clear change for pretix and supabase), so left unedited and unmarked.

Checks

On head: readme-sync 6 passed; check:agent-docs exit 0.


Summary by cubic

Updates the README's Alamofire benchmark so the 2026-10-14 figure is no longer presented as the fork's current result. That run predates the resolver pool change (#506); the README now adds a note with the two later results and clarifies the later wall-time comparison found no clear difference.

Written for commit c23eeb8. Summary will update on new commits.

View guided diff Turn on auto-fix

… change

The row is from the 2026-10-14 run (fork ba97227). After the pool started part-way through on mid-size projects, the 2026-10-15 comparison has the fork at 1.44 s and 1,042 MiB against upstream's 1.38 s and 791 MiB, and a three-run check of the current build took 1.31 to 1.61 s at 919 to 930 MiB.
@coderabbitai

coderabbitai Bot commented Oct 18, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 074d8f39-84f2-4855-b538-46e4d8ddc694
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 18, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The documentation change appears safe to merge.

Summary

The README marks the Alamofire row as historical and adds later measurements.

  • The README marks its Alamofire result as an older measurement.

Reviews (1) · Last reviewed commit: "docs: note that the README's Alamofire r..." · Reviewed by Greptile

@bompus
bompus merged commit 2cdd552 into fork/consolidated Oct 18, 2026
3 checks passed
@bompus
bompus deleted the docs/readme-alamofire-figures branch October 18, 2026 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant