Repository navigation
docs: re-run the fork-vs-upstream benchmark on 633fc82c against upstream 986de95c - #527
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
[Low impact] The documentation changes appear safe to merge. SummaryRefreshes the README and benchmark charts with the 2026-10-18 comparison of fork
Reviews (1) · Last reviewed commit: "docs: re-run the fork-vs-upstream benchm..." · Reviewed by Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Against upstream's current
main, the fork indexes n8n 1.3 times faster (66.3 s against 84.5 s on Node), syncs one edited file 3.0 times faster and is better in 65 of 74 comparisons, about the same in 4 and worse in 5.The README's "Measured results" quoted the 2026-10-14 run (fork
ba972275, upstream3f714bcc). Since then the fork gained the mid-size resolver pool (#506), the Kotlin, regex-cache and WAL-checkpoint changes (#515 to #519), imported-constant member links (#523) and the markup arrow-parameter guard (#526). This repeats the same run with the same scripts, corpora, arms and quiet-host rule on fork633fc82cand upstream986de95c(Node 24.22.0, Bun 1.4.3, 16-vCPU WSL2 host, mirrored arm order, index median of 2, sync median of 4). The fork lacks one upstream commit,986de95c, a Vue import fix, so the arms differ in it. Protocol written before the first timed run; no attempt was rejected; all steps returned 0 apart from upstream's supabase syncs, which fail withFOREIGN KEY constraint failedas before (colbymchenry#2565) and stay out of the 74.What moved in the README, Node arms (the full tables are in the new doc):
The worse five are pretix indexing (+13% Node, +20% Bun) and index memory on Alamofire (+15% Node) and pretix (+11% Node, +6% Bun). Each percentage is a median of two runs, so a difference within 3% is called no clear change, and the host was faster than on 10-14, so compare ratios between arms and not seconds across runs. Not measured: Windows and macOS, a second Bun or Node version.
Changes:
README.md(Measured results, the four tables, the Node-or-Bun paragraph, the "Slower to index" bullet),assets/fork-vs-upstream-performance.svg(version tag bumped to?v=4), the newdocs/benchmarks/fork-vs-upstream-node-bun-2026-10-18.mdand its heatmap. The 10-14 doc stays as a dated record. Every figure comes fromrender-charts.mjsand a script over the raw rows; the README tallies come from the chart renderer.README rows checked: the "Measured results" intro, chart alt text, the full-index, sync, MCP and CLI tables, the Alamofire note and the Python-regression paragraph, the Node-or-Bun paragraph, and the "What it costs" bullets. Unchanged on purpose: the mid-size paragraph (its own 10-15 and 10-17 measurements), database size and edge-count bullets (the percentages round to the same values).
readme-syncandcheck:agent-docspass.Summary by cubic
Re-runs the fork-vs-upstream benchmark on the current commits (fork
633fc82cagainst upstream986de95c) and updates the README's Measured results with the new numbers, chart, and benchmark doc. The fork now indexes n8n 1.3× faster, syncs an edited file 3.0× faster, and is better in 65 of 74 comparisons (up from 61). The run includes the recent resolver pool, Kotlin, regex-cache, WAL-checkpoint, and import-link changes, so Alamofire's index memory is now higher (+15% on Node). The 2026-10-14 doc stays as a dated record.Written for commit 0a96fc1. Summary will update on new commits.