Repository navigation
remove BOOST_NO_STD_ITERATOR_TRAITS from isomorphism.hpp - #648
Open
andreacassioli wants to merge 1 commit into
Open
andreacassioli wants to merge 1 commit into
andreacassioli wants to merge 1 commit into
Conversation
andreacassioli
marked this pull request as ready for review
October 14, 2026 20:15
andreacassioli
requested review from
Becheler and
jeremy-murphy
as code owners
October 14, 2026 20:15
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! 🚀 New features to boost your workflow:
|
|
Boost dependency footprint vs Header-inclusion weights (graph files pulling each direct dependency in): No header-inclusion-weight changes. Transitive Boost modules: 47 → 47 (0) |
|
Compiler-warning counts vs
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Important
New algorithms and API additions need a design issue first. Such a PR is not reviewed until an issue has settled the API and frozen the scope. PRs whose scope grows under review go stale. See How To Contribute an Algorithm.
Motivation
Part of #593
What this PR does
Remove BOOST_NO_STD_ITERATOR_TRAITS from isomorphism.hpp. There are two cases:
safe_iterator_property_maptype: there the additional templates provided if the macro is used are deduced from the iterator traits as default.make_safe_iterator_property_map, if the macro is used than the value type is deduced from a value passed to the function, a value that is actually unused in the function.Both cases are safe to removed, as their behavior won't change.
Only one note: the same macro is used in the definition of the safe_iterator_property_map, out of BGL.
Before submitting
developbranch.Kind of change
Tick exactly one. Each kind is reviewed differently, so mixing them in one PR makes the diff difficult to review (why).
Change category