fix(cli): record a timed-out mocha test's failure when mocha reports it (SDK-7843) [v8]

[AakashHotchandani]

What is this about?

v8 port of #272. On the CLI flow, a mocha test that hits mocha's timeout has its session marked passed on the Automate / App Automate dashboard.

Why: wdio runs afterTest inside the test's runnable. When the test times out, mocha fails it (and emits fail to reporters) while the body and its afterTest are still pending. With bail, or on the worker's last test, wdio runs after() first. after() emits EXECUTE/POST, and AutomateModule.onAfterExecute marks the session from results that only afterTest supplies. There is none yet, so the session is marked passed. The classic flow reads after(result), mocha's own failure count, and was correct.

Same fix as #272:

• cli/earlyTestFinish.ts (identical file): beforeTest (CLI, mocha) registers a finisher per test.
• The reporter's onTestFail reports the failure through it, with mocha's own result, the moment mocha fails the test.
• after() awaits those finishes before EXECUTE/POST.
• afterTest stands down only for a test the reporter already reported.

The CLI finish (LOG_REPORT/POST → TEST/POST) moved unchanged into finishCliTest(), including the existing suiteTite payload key.

Difference from main: v8 has no deferred TEST/POST and no bail cascade, so its Test Reporting results were already right. On v8 this fixes the session status only.

Also in this PR — the resolveInstance ERROR (same change as #265): console output from wdio's before hook (the customer's [SelfHealer] Installed …) reaches trackEvent(LOG, POST) before mocha's first hook, when no test or hook instance exists. resolveInstance then printed resolveInstance: unable to resolve/create instance for TestFrameworkState.LOG HookState.POST on every worker. WdioMochaTestFramework.trackEvent now drops a LOG with no tracked instance at debug level, as the classic flow does. New test: tests/cli/wdioMochaTestFramework.preTestLog.test.ts (3 cases). Verified on real sessions under #265: stock 8.53.1 build smosjpekx4… prints the ERROR, patched build djju5rlyfb… is clean.

Review follow-up (ab144e5):

• No reporter: same fallback as fix(cli): record a timed-out mocha test's failure when mocha reports it (SDK-7843) #272. after() finishes any test mocha already failed that no reporter claimed, before EXECUTE/POST.
• Retries: per-attempt keys, as in fix(cli): record a timed-out mocha test's failure when mocha reports it (SDK-7843) #272.
• Cleanup: removed the unreachable try/catch in after().
• Tests: 18 SDK-7843 timeout tests plus 3 pre-test-log tests. Full suite: 1138/1138 passed, 51/51 files.

Verification

Real WDIO 8 + mocha sessions on Automate (chrome/Win11), mochaOpts: { timeout: 10000, bail: true }. The timed-out test waits 40 s for a missing element.

build	SDK	session status of the timed-out test	Test Reporting
gceel2cz0bnksiupe9w90rzx7ttnf06w4dgaqj8n	stock 8.53.1	3eeef5f73f174165fb02f17f6616041f43656360 passed ❌ (CLIENT_STOPPED_SESSION)	passed 1, failed 1
niszt4uhggs0bb2nnia3ngxookl2oemckau8wrmc	this PR	0c835059b01822990f4e38cb092af6a9a934d438 failed, reason = mocha timeout	passed 1, failed 1

Timing on both runs: reporter onTestFail (05:53:48.831) → after(result=1) (.840). On stock, the session status is set before the failed result exists.

Tests: the same 11 new cases as #272.

• tests/cli/earlyTestFinish.test.ts and tests/reporter.onTestFail.test.ts are identical to fix(cli): record a timed-out mocha test's failure when mocha reports it (SDK-7843) #272.
• tests/service.timedOutTestFinish.test.ts is adapted: it has no flush step and asserts TEST/POST < EXECUTE/POST. Mutation-checked: dropping the await in after() fails it.

Full suite: 1131 passed with this PR (51/51 files) vs 1109 on v8, 0 failing tests on both. The only failing file is tests/crash-reporter.test.ts (needs a built build/), and it fails identically on v8. tsc -p tsconfig.prod.json --noEmit is clean. The v8 branch has no eslint config.

Related Jira task/s

SDK-7843

Release (mandatory for every PR — required for the ready-for-review label)

Version bump: (required — tick exactly one)

• minor (backwards-compatible feature)
• patch (bug fix or other small change)

Release notes type: (optional)

• New Feature
• Bug Fix
• Other Improvement

Release notes (customer-facing): (optional but encouraged)

• Fixed mocha tests that fail by exceeding their timeout being marked "passed" on the Automate / App Automate dashboard. Such sessions are now marked failed, with the timeout error as the reason.
• Removed the resolveInstance: unable to resolve/create instance ... LOG POST error printed when a wdio before hook writes to the console.

Release notes (internal): (required — engineer-facing; what actually changed / why)

• v8 port of fix(cli): record a timed-out mocha test's failure when mocha reports it (SDK-7843) #272. New cli/earlyTestFinish.ts: beforeTest (CLI, mocha) registers a finisher per test; reporter onTestFail reports a failure through it when mocha fails the test; after() awaits those finishes before EXECUTE/POST; afterTest stands down only for a test already reported. Root cause: for a mocha timeout under bail (or on a worker's last test) wdio runs after() before afterTest, so AutomateModule.onAfterExecute marked the session from an empty result map (passed). Also (as fix(cli): drop a log written before the first mocha hook instead of logging an ERROR (SDK-7843) [v8] #265): WdioMochaTestFramework.trackEvent drops a LOG event with no tracked instance at debug level instead of logging the resolveInstance ERROR.

Checklist

• Ready to review
• Has it been tested locally?

PR Validations

Run Tests: Comment RUN_TESTS to trigger sanity tests.

🤖 Generated with Claude Code

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

• Configuration used: Central YAML (base), Organization UI (inherited), Workspace UI (inherited)
• Review profile: ASSERTIVE
• Plan: Enterprise
• Run ID: 64596c73-14cd-4e4c-8862-68ef79a31da6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

• Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

🔴 SDK PR Review gate is red. Pending:

• The SDK PR Review Agent has not been run on the current head commit yet — run the SDK PR Review Agent (its verdict is advisory; this gate only requires that it ran on the latest commit).

It turns green once the SDK PR Review Agent has run on the current head commit (any verdict — the gate only requires that the review ran). A native reviewer approval is separately required by branch protection before merge.

[github-actions]

🔴 SDK PR Review gate is red. Pending:

• The SDK PR Review Agent has not been run on the current head commit yet — run the SDK PR Review Agent (its verdict is advisory; this gate only requires that it ran on the latest commit).

It turns green once the SDK PR Review Agent has run on the current head commit (any verdict — the gate only requires that the review ran). A native reviewer approval is separately required by branch protection before merge.

[github-actions]

🔴 SDK PR Review gate is red. Pending:

• The SDK PR Review Agent has not been run on the current head commit yet — run the SDK PR Review Agent (its verdict is advisory; this gate only requires that it ran on the latest commit).

It turns green once the SDK PR Review Agent has run on the current head commit (any verdict — the gate only requires that the review ran). A native reviewer approval is separately required by branch protection before merge.

[github-actions]

🔴 SDK PR Review gate is red. Pending:

• The SDK PR Review Agent has not been run on the current head commit yet — run the SDK PR Review Agent (its verdict is advisory; this gate only requires that it ran on the latest commit).

It turns green once the SDK PR Review Agent has run on the current head commit (any verdict — the gate only requires that the review ran). A native reviewer approval is separately required by branch protection before merge.