Remove component names subsumed by external-id - #2735
Merged
alexcrichton merged 1 commit intoOct 5, 2026
Merged
Conversation
This commit removes support for component names of the form `unlocked-dep=<...>`, `locked-dep=<...>`, `url=<...>` and `integrity=<...>`. These were removed upstream in WebAssembly/component-model#672 in favor of the `external-id` attribute/annotation. I'm not aware of anyone actually using these forms of imports anywhere in the ecosystem so the expected impact of this change in theory is negligible. If there are users, however, these can always be re-added with a more phased deletion plan.
pchickey
approved these changes
Oct 5, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit removes support for component names of the form
unlocked-dep=<...>,locked-dep=<...>,url=<...>andintegrity=<...>. These were removed upstream inWebAssembly/component-model#672 in favor of the
external-idattribute/annotation. I'm not aware of anyone actually using these forms of imports anywhere in the ecosystem so the expected impact of this change in theory is negligible. If there are users, however, these can always be re-added with a more phased deletion plan.