Skip to content

Fix Rector dependency resolution - #1117

Merged
dereuromark merged 1 commit into
5.xfrom
fix-rector-phpstan
Sep 15, 2026
Merged

dereuromark merged 1 commit into
5.xfrom
fix-rector-phpstan

Conversation

@dereuromark

Copy link
Copy Markdown
Member

The cs-stan job started failing while Rector initialized:

MissingPrivatePropertyException: Property "$container" was not found in "PHPStan\Parser\RichParser"

Rector 2.3.9 allows PHPStan 2.2, but its container integration still depends on the PHPStan 2.1 RichParser implementation. Constrain the temporary Rector installation to PHPStan 2.1 until Rector can be upgraded.

This keeps the existing Rector 2.3 rule set. Upgrading Rector instead would make the dry run propose changes to 120 files.

Verified with:

composer rector-setup
composer rector-check
composer cs-fix
composer phpstan
vendor/bin/phpunit tests/TestCase/TestSuite/MigratorTest.php

@dereuromark
dereuromark merged commit 27da5a5 into 5.x Sep 15, 2026
14 checks passed
@dereuromark
dereuromark deleted the fix-rector-phpstan branch September 15, 2026 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant