Repository navigation
Conversation
josbeir
force-pushed
the
fix/6.x-cakephp-compatibility
branch
from
October 7, 2026 07:17
e486468 to
aab7b74
Compare
josbeir
marked this pull request as draft
October 7, 2026 07:17
josbeir
marked this pull request as ready for review
October 7, 2026 07:25
josbeir
force-pushed
the
fix/6.x-cakephp-compatibility
branch
from
October 7, 2026 07:27
aab7b74 to
71e6ab0
Compare
josbeir
force-pushed
the
fix/6.x-cakephp-compatibility
branch
from
October 7, 2026 07:41
71e6ab0 to
194100b
Compare
Member
|
Took a quick skim through it and it looks fine. |
LordSimal
approved these changes
Oct 9, 2026
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
6.xbranch still requires CakePHP 5 components and uses the old command/Bake APIs, so a CakePHP 6 application cannot install and use it. These two commits add CakePHP 6 compatibility and apply its code standards. The branch sync is already in6.xand is not part of this PR.Commands and Bake commands use inherited argument/IO properties and updated method signatures. Migration managers, environments, seeds and adapters accept
ConsoleIoInterface, with a regression test verifying that an interface implementation reaches the adapter. Schema setters match CakePHP 6's fluent return types. MySQL preserves the existing BINARY/VARBINARYfixedoption behavior under CakePHP 6 schema types. SQL Server maps CakePHP 6's VARBINARY schema type to the existing Migrations BINARY type; two isolated regression tests cover both BINARY and VARBINARY metadata.Dependencies and CI move to PHP 8.4+, CakePHP 6, Bake 4, CodeSniffer 6 and PHPUnit 12/13. Serialized schema comparison fixtures are refreshed for CakePHP 6's renamed properties; upgrading applications are instructed to regenerate schema dumps before baking diffs. Rector's existing PHP 8.2 language rules are retained explicitly to keep unrelated language modernization out of this upgrade.
Validation on PHP 8.5.11:
All 18 GitHub checks pass, including the PHP 8.4/8.5 Linux matrix for SQLite, MySQL, MariaDB and PostgreSQL, lowest dependencies, Windows PHP 8.4/SQL Server, coding standards/static analysis and documentation checks. Existing test warnings/deprecations/notices and database-specific skips remain.