Skip to content

refactor(capture): require complete runtime snapshots #3642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 2 commits into from
Oct 15, 2026
Merged

refactor(capture): require complete runtime snapshots #3642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
add06f4
refactor(capture): require complete runtime snapshots
thymikee Oct 15, 2026
b008614
test(capture): distinguish runtime and capture clocks
thymikee Oct 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions packages/contracts/src/backend.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,9 @@ import type {
import type {
Point,
Rect,
SnapshotKeyboardBandFact,
SnapshotNode,
SnapshotOptions,
SnapshotState,
SnapshotViewportSize,
} from '@agent-device/kernel/snapshot';

// The backend's public leaf platform (approach b): backends distinguish iOS from
Expand All @@ -45,25 +43,10 @@ export type BackendCommandContext = {
};

export type BackendSnapshotResult = {
nodes?: SnapshotNode[];
truncated?: boolean;
backend?: string;
snapshot?: SnapshotState;
snapshot: SnapshotState;
appName?: string;
appBundleId?: string;
snapshotDiagnostics?: SnapshotDiagnosticsSummary;
/**
* The keyboard band this capture's producer measured (#2660), carried beside the tree it measured.
* A backend that publishes nothing measured nothing, and the tap-path keyboard guard keeps deriving
* the band from `nodes`.
*/
keyboard?: SnapshotKeyboardBandFact;
/**
* The box these rects are measured in, as the producer measured it (#3182). Absent means the
* producer measured no box — never a zero — since that absence is the only answer a producer with
* no screen to measure is allowed to give.
*/
viewport?: SnapshotViewportSize;
} & SnapshotCaptureAnnotations;

export type BackendSnapshotOptions = SnapshotOptions & {
Expand Down
Loading
Loading