feat: add typed leading and trailing slots to List.Item - #5042
Draft
adam-sajko wants to merge 21 commits into
Draft
adam-sajko wants to merge 21 commits into
adam-sajko wants to merge 21 commits into
Conversation
adam-sajko
force-pushed
the
feat/list-typed-slots
branch
2 times, most recently
from
August 24, 2026 09:48
96e1127 to
aba3b2a
Compare
This was referenced Aug 25, 2026
adam-sajko
force-pushed
the
feat/list-typed-slots
branch
7 times, most recently
from
September 3, 2026 11:09
e155220 to
c692ed1
Compare
adam-sajko
force-pushed
the
feat/list-typed-slots
branch
from
September 8, 2026 09:24
c692ed1 to
ec5685e
Compare
…s-spacing # Conflicts: # src/components/List/ListItem.tsx # src/components/__tests__/ListAccordion.test.tsx # src/components/__tests__/ListImage.test.tsx
…nd-accordion-animation
…ist-typed-slots # Conflicts: # src/components/List/ListItem.tsx
…nd-accordion-animation
|
Found potential problems with the pull request:
|
…nd-accordion-animation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
List.Itemlayout is tied to theleftandrightrender props: they hand the caller astyleand acolorand trust them to apply both.leadingandtrailingtake a node instead, soList.Itemowns the layout. They take precedence overleftandrightwhen both are passed.Related issue
Related to #4930 and #4976
Draft, stacked on #5041 and #5057.
Test plan
Open the List example, check the leading and trailing slots render and pick up the item color, including in a selected row.