fix: Remove top-level paths for code lists

[daogrady]

Fixes #173
Specifically addresses behaviour reported in a comment, whereas the original issue was addressed in #177

Before fix:
routes for OrderItems code list exist on top level

After fix:
routes are no longer available on top level, but can be accessed via the navigation paths POST /Orders({ID})/items etc.

[tim-sh]

Looks good – just to be sure, one question, plus could you double-check that top-level GET paths for value-help code lists (e.g. Currencies) still work?

[daogrady]

could you double-check that top-level GET paths for value-help code lists (e.g. Currencies) still work?

Good catch. That was indeed incorrectly hidden, but is now shown again.

[tim-sh]

Looks good to me; just a nit I found.

[tim-sh]

This line can now read:

                if (serviceType?.['@cds.autoexposed'] && !serviceType?.['@cds.autoexpose']) {

[daogrady]

I don't follow. This would change the semantics of the condition.

Currently:

@cds.autoexposed
entity A {}  // ✅

@cds.autoexpose
entity B {}  // ✅

@cds.autoexposed
@cds.autoexpose
entity C {}  // ✅

would all pass the condition. With your suggestion, we'd have:

@cds.autoexposed
entity A {}  // ✅

@cds.autoexpose
entity B {} // ❌

@cds.autoexposed
@cds.autoexpose
entity C {} // ❌

[tim-sh]

There's a misunderstanding – my suggestion refers to l.132 only, i.e. just replace the extracted expression with the new var name.

[daogrady]

ah, I see! I missed the other uses of the new variable

[daogrady]

my bad, the coloured highlighting of line 129 diverted my attention from the line 132 you actually attached your comment to. I have changed it accordingly.