Name the OLM bundle directory without the v prefix - #761
Merged
cert-manager-prow[bot] merged 1 commit intoSep 30, 2026
Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager-prow[bot] merged 1 commit into
Conversation
Red Hat's operator pipeline now rejects a bundle whose directory name differs from the CSV version, e.g. operators/foo/v1.2.3 for version 1.2.3. Signed-off-by: Richard Wall <richard.wall@cyberark.com> Co-Authored-By: Claude <noreply@anthropic.com>
cert-manager-prow
Bot
added
dco-signoff: yes
cert-manager-prow
Bot
added
the
approved
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: inteon The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
olm-publishcopies the bundle tooperators/<name>/$(VERSION), for exampleoperators/vcp-operator/v1.10.0. Red Hat's certified-operators pipeline now rejects that. The directory name must equal the CSV version, which has novprefix. This change strips thevfrom the directory name only. The branch name, commit message and PR title still use$(VERSION), as before.This is a short-term fix. We still want to remove the OLM tooling in #653 once it is no longer used, as @inteon said in #653 (comment). Until then, every release published with this module fails Red Hat's static tests.
The failing check and how I tested the fix
Red Hat added the check
check_operator_version_directory_namein January 2026 (redhat-openshift-ecosystem/operator-pipelines@6607b3f11). Its documentation says:redhat-openshift-ecosystem/certified-operators#9766 hit it:
After I renamed the directory to
1.10.0on that PR, the static tests passed and Red Hat merged and published it.To test the change, I copied it into a project that vendors this module and ran
make -n olm-publish VERSION=v1.10.0. The recipe now copies and addsoperators/vcp-operator/1.10.0, while the branch and PR title stayv1.10.0:[with Claude]