Repository navigation
ENT-14702: Reuse watcher state between policy reload - #6376
Merged
Merged
Conversation
victormlg
changed the title
victormlg
force-pushed
the
cf-reactor.ReusePolicyState
branch
from
October 5, 2026 11:43
a982c7d to
a63277f
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
victormlg
marked this pull request as draft
October 5, 2026 12:07
victormlg
force-pushed
the
cf-reactor.ReusePolicyState
branch
from
October 8, 2026 09:12
a63277f to
4d3df52
Compare
victormlg
marked this pull request as ready for review
October 8, 2026 09:14
larsewi
approved these changes
Oct 8, 2026
victormlg
force-pushed
the
cf-reactor.ReusePolicyState
branch
2 times, most recently
from
October 9, 2026 12:55
292b20d to
32f2782
Compare
Contributor
Author
|
@cf-bottom jenkins, please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14771/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14771/ |
Instead of destroying all watchers, it now keeps the state, such that, even if an event happens during policy reload, it will get detected by comparing the previous state. Ticket: ENT-14702 Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor.ReusePolicyState
branch
from
October 12, 2026 10:05
32f2782 to
e10206a
Compare
Contributor
Author
|
@cf-bottom jenkins, please :) |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14790/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14790/ |
larsewi
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Between each policy reload, the watcher state is discarded, however, if the promise is identitical, we would like to be able to detect the changes that happened during the reload. Thus, we need to pass the watcher states.