Repository navigation
CFE-3041: Made testall fail regular acceptance tests which log errors - #6405
Draft
aleksandrychev wants to merge 1 commit into
Draft
aleksandrychev wants to merge 1 commit into
aleksandrychev wants to merge 1 commit into
Conversation
Tests that print Pass message but have logs errors will fail with `FAIL (Error printed)` message. Tests which are expected to log errors should use `.error.cf` or `.error.pass.cf` suffix. see: `tests/acceptance/README` Ticket: CFE-3041 Signed-off-by: Ihor Aleksandrychiev <ihor.aleksandrychiev@northern.tech>
Contributor
Author
|
@cf-bottom jenkins please |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14799/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14799/ |
olehermanse
requested changes
Oct 14, 2026
olehermanse
left a comment
olehermanse
left a comment
Member
There was a problem hiding this comment.
This cannot be done on its own - there are hundreds of tests that need to be reviewed and adjusted after this change in testall.
Contributor
Author
I see, there are quite a lot of them. So, we need to identify which ones are expected and should be renamed, and also find the ones that shouldn't be there. As a first step, I'll create a table listing each failure and the errors printed. |
aleksandrychev
marked this pull request as draft
October 14, 2026 18:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tests that print Pass message but have logs errors will fail with
FAIL (Error printed)message. Tests which are expected to log errors should use.error.cfor.error.pass.cfsuffix. see:tests/acceptance/READMETicket: CFE-3041