Skip to content

fix leak of uninitialized stack memory in CfGetFile refusal replies #6408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
larsewi merged 1 commit into from
Oct 15, 2026
Merged

fix leak of uninitialized stack memory in CfGetFile refusal replies #6408

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion cf-serverd/server_common.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -415,7 +415,10 @@ void CfGetFile(ServerFileGetState *args)

int fd;
off_t n_read, total = 0, sendlen = 0, count = 0;
char sendbuffer[CF_BUFSIZE + 256], filename[CF_BUFSIZE - 128];
/* sendbuffer is zero-initialized because the access-refused and open-error
* paths below send args->buf_size bytes of it after writing only a short
* CF_FAILEDSTR, and args->buf_size is chosen by the client. */
char sendbuffer[CF_BUFSIZE + 256] = { 0 }, filename[CF_BUFSIZE - 128];
struct stat sb;
int blocksize = 2048;

Expand Down
Loading