Repository navigation
fix: include title width when fitting vertical legends - #12330
Open
minwookshin wants to merge 1 commit into
Open
minwookshin wants to merge 1 commit into
minwookshin wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A long title in a left or right legend can be clipped even when the chart has room. Include the title’s measured width and horizontal padding when fitting a vertical legend, while retaining the configured width limit.
Fixes #11850.
Validation: all 82 legend tests pass in Chromium and Firefox, including five new cases covering both sides, font sizes, hidden titles, and
maxWidth.pnpm lint(including type tests) passes. The full Chromium suite passes 1,701 tests; seven unrelated image fixtures fail identically on unchanged upstream7169e65(1,696 passing), so no reference images were changed.