Skip to content

fix: read account address from list_transports() - #23

Merged
j4n merged 1 commit into
mainfrom
j4n/configured-addr
Oct 13, 2026
Merged

j4n merged 1 commit into
mainfrom
j4n/configured-addr

Conversation

@j4n

@j4n j4n commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Core as of 2.63 no longer provides the addr key, so get_config("addr") returned None and cmping crashes when joining the receiver addresses:

~ % uvx cmping --reset ci-chatmail.testrun.org -c 1
# using accounts_dir for ci-chatmail.testrun.org at: /home/ja/.cache/cmping/ci-chatmail.testrun.org
# Setting up profiles... Done!                             
# Waiting for profiles to be online... Done!               
Traceback (most recent call last):
[...]
  File ".../site-packages/cmping.py", line 628, in __init__
    self.receivers_addrs_str = ", ".join(self.receivers_addrs)
                               ~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^
TypeError: sequence item 0: expected str instance, NoneType found

Fix: read instead from get_config("configured_addr")

@missytake missytake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to be future-proof, configured_addr will vanish soon as well: chatmail/core#8572

@j4n
j4n force-pushed the j4n/configured-addr branch from 70c6c49 to 732a4a9 Compare October 13, 2026 14:48
@j4n j4n changed the title fix: read account address from configured_addr fix: read account address from list_transports() Oct 13, 2026
Delta Chat core 2.63 stopped writing the legacy addr key, so get_config("addr")
returned None and crashes cmping crashed when joining.
@j4n
j4n force-pushed the j4n/configured-addr branch from 732a4a9 to f0a9e5f Compare October 13, 2026 15:02
@j4n

j4n commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

This doesn't seem to be future-proof, configured_addr will vanish soon as well: chatmail/core#8572

ok, redid it akin to cmlxc#51 by using account.list_transports()

@missytake missytake left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great :)

@j4n
j4n merged commit 3671827 into main Oct 13, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants