Repository navigation
ci(claude-review): switch the review off behind CLAUDE_REVIEW_ENABLED - #1007
Conversation
The review is meant to be advisory, but the 'Require completed Claude review' gate failed the check whenever Claude did not finish: on #1006 it ran out of turns, and a cancelled re-run still reported a failure because the gate runs under always(). Gate the job on the repository variable CLAUDE_REVIEW_ENABLED == 'true'. It is unset, so the job is skipped (a neutral check, not a failed one) until the review is made advisory, and it can be switched back on without a pull request.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
2 participants
Summary
The automated Claude pull-request review is meant to be advisory, but it is marking pull requests with a failed check. On #1006 the review ran out of turns, and a cancelled re-run still reported a failure. This turns the review off: the job now runs only when the repository variable
CLAUDE_REVIEW_ENABLEDis'true'. The variable is not set, so after merge thereviewcheck shows as skipped (grey) instead of failed. Setting the variable turns it back on without another pull request.Changes
.github/workflows/claude-review.yml: thereviewjob'sif:now starts withvars.CLAUDE_REVIEW_ENABLED == 'true' &&; a comment says why and how to re-enable.scripts/__tests__/claude-review-workflow.test.mjs: asserts the switch is the first clause of the condition.scripts/__tests__/workflow-dispatch-job-conditions.test.mjs: holds the new variable open in its synthetic contexts (as it already does forneeds), so the fork-guard test still tests only the fork guard.Verification
pnpm run test:scripts: 54 files, 938 passed, 1 skipped.biome checkclean on both test files.gh variable listshows noCLAUDE_REVIEW_ENABLED, so the job will skip once this merges.pull_requestruns the workflow from the pull request head, so this PR's ownreviewjob already uses the new condition and should show as skipped once it is marked ready.Related
Refs #974, #1006
Review notes
What failed on #1006, for the follow-up that makes the review advisory and re-enables it:
error_max_turns(26 turns against--max-turns 25, 6 refused tool calls, $0.45). The PR touches 28 files.if: always(), so it still failed the job.The follow-up should put
continue-on-error: trueon the review step, make the gate warn instead of fail, run it under!cancelled(), raise--max-turns, and log refused tool calls.No changeset: CI workflow and repo tests only.