Repository navigation
Conversation
Collaborator
|
will go through your patches next week. I'd like to upgrade hea with polars 2.0 first and cleared all upstream compatibility first. thanks for the help. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid small-angle samples are rejected as degenerate because the Fisher–Lee and Jammalamadaka–SenGupta implementations compare positive variance terms with an absolute
np.isclose(..., 0)tolerance. For example:Both currently raise despite nonconstant input and unit self-correlation. Accept positive representable denominator and fourth-moment values. Keep constant and antipodal inputs degenerate by checking raw-angle sine residuals against argument-scale rounding, rather than imposing a fixed variance floor.
The new regressions cover small nonconstant samples, both inference modes, nonzero constants, antipodal directions and full-turn aliases. Nine configurations fail on unchanged main; all 28 pass afterward. The full suite passes 394 tests with
hea==0.1.2; the fatal Flake8 gate passes. The existing latest-Hea collection limitation noted in #23 is unchanged.A separate workload uses unmodified recorded KITTI OXTS roll/pitch/yaw windows. All 168 public calls that previously failed now agree with independent scalar pair sums/rescaled-moment references within 7.4e-11. Nine ordinary bundled-data controls remain exact. These checks establish numerical evaluation, not calibration of inference on serial sensor data. #21's current head still reproduces the failures. This is separate from #23's jackknife standard-error correction; extremely small products can still underflow.