Repository navigation
rust-openssl sync - #482
Merged
Merged
Conversation
Collaborator
|
Need to configure AI reviews for this repo |
kornelski
force-pushed
the
openssl-sync
branch
from
August 15, 2026 01:54
7e5b153 to
c344588
Compare
kornelski
force-pushed
the
openssl-sync
branch
from
October 14, 2026 09:58
c344588 to
8c12531
Compare
Lekensteyn
self-requested a review
October 14, 2026 12:01
Lekensteyn
approved these changes
Oct 14, 2026
Lekensteyn
left a comment
Lekensteyn
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. One minor nit (feel free to ignore), and another question about is_on_curve.
Lekensteyn
reviewed
Oct 14, 2026
kornelski
force-pushed
the
openssl-sync
branch
from
October 14, 2026 19:06
8c12531 to
5de6e63
Compare
kornelski
force-pushed
the
openssl-sync
branch
from
October 14, 2026 19:28
5de6e63 to
7df672e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've diffed API with rust-openssl and implemented some low-hanging fruit.