Repository navigation
Conversation
… not_before Signed-off-by: Sebastian Turner <sebastiant3484@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SigningProfile.populaterejects a profile whosenot_afteris before itsnot_before, but it passes a nilerrtocferr.Wrap, which panics. Soconfig.LoadConfig(andcfssl serve -config,cfssl gencert -config) crash with "Wrap needs a supplied error to initialize." on such a config instead of reporting it as invalid.This change passes a descriptive error to
cferr.Wrap, so the profile is rejected with anInvalidPolicyerror.Testing: added
TestNotAfterBeforeNotBeforeinconfig/config_test.go. It panics on master and passes with this change.go test ./config/passes.Fixes #1456