Repository navigation
Make drain plugin drain spec deterministic - #5457
Merged
philippthun merged 1 commit intoOct 9, 2026
Merged
Conversation
johha
reviewed
Oct 7, 2026
philippthun
force-pushed
the
fix-drain-plugin-spec-race
branch
from
October 8, 2026 09:46
659fa78 to
db37786
Compare
The 'works off all remaining jobs before exiting' example raced the worker loop against TERM signal delivery. On slow/contended runners the drain flag (exit_on_complete) flipped late, so work_off ran extra times and the count inflated past 3. Block the worker after its first work_off call until the test confirms the drain TERM handler has set exit_on_complete, then release it. This removes the timing dependency and makes the call count deterministic.
philippthun
force-pushed
the
fix-drain-plugin-spec-race
branch
from
October 8, 2026 09:48
db37786 to
3ccd512
Compare
johha
approved these changes
Oct 8, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Oct 9, 2026
Changes in cloud_controller_ng:
- Make drain plugin drain spec deterministic
PR: cloudfoundry/cloud_controller_ng#5457
Author: Philipp Thun <philipp.thun@sap.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 'works off all remaining jobs before exiting' example raced the worker loop against TERM signal delivery. On slow/contended runners the drain flag (
exit_on_complete) flipped late, sowork_offran extra times and the count inflated past 3.Block the worker after its first
work_offcall until the test confirms the drain TERM handler has setexit_on_complete, then release it. This removes the timing dependency and makes the call count deterministic.This change was developed with AI assistance; all code was reviewed and tested by me.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests