Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unread annotations on a Python 3.14 dynamic class are lost when the class is pickled by value. A fresh-process round trip of
class C: x: intreturns an empty annotation dictionary unless its annotations were accessed first.Materialize the native annotation cache before sorted class-state extraction, only for an owned lazy annotation function whose cache has not been populated. The snapshot retains the existing cache representation while excluding the annotation closure. Fresh-process regressions cover unread/read annotations, class-local/self/resolved references, derived classes, cached metaclass getters/setters and deterministic chained pickling.
Annotations are evaluated when dumping, consistent with dynamic function annotations. Unresolved bare names therefore raise
NameErrorduring dumping; quoted references and future-import annotations retain their string values. This behavior is recorded in the changelog.Fixes #608.
Validation:
git diff --checkpass.AI assistance: OpenAI Codex prepared the implementation, regression tests and changelog, ran the checks, and performed a separate agent review of the final patch.