appendToList silently adds TypeString only

[motoshkov]

Add appendToList for every Type.
here is the diff:

diff --git a/python-libconfig/src/pylibconfig.cc b/python-libconfig/src/pylibconfig.cc
index becaeee..238831f 100644
--- a/python-libconfig/src/pylibconfig.cc
+++ b/python-libconfig/src/pylibconfig.cc
@@ -156,9 +156,39 @@ public:
         config->lookup ( path ).add ( name, libconfig::Setting::TypeArray );
     }

-    void appendToList ( const char * path, const char * value )
+    void appendBooleanToList ( const char * path )
     {
-        config->lookup ( path ).add ( libconfig::Setting::TypeString ) = value;
+        config->lookup ( path ).add ( libconfig::Setting::TypeBoolean );
+    }
+
+    void appendBigIntegerToList ( const char * path )
+    {
+        config->lookup ( path ).add ( libconfig::Setting::TypeInt64 );
+    }
+
+    void appendIntegerToList ( const char * path )
+    {
+        config->lookup ( path ).add ( libconfig::Setting::TypeInt );
+    }
+
+    void appendFloatToList ( const char * path )
+    {
+        config->lookup ( path ).add ( libconfig::Setting::TypeFloat );
+    }
+
+    void appendStringToList ( const char * path )
+    {
+        config->lookup ( path ).add ( libconfig::Setting::TypeString );
+    }
+
+    void appendGroupToList ( const char * path )
+    {
+        config->lookup ( path ).add ( libconfig::Setting::TypeGroup );
+    }
+
+    void appendArrayToList ( const char * path )
+    {
+        config->lookup ( path ).add ( libconfig::Setting::TypeArray );
     }

     void setValue_bool ( const char * path, bool value )
@@ -201,6 +231,16 @@ public:
         config->lookup ( path ) = value;
     }

+    void setIncludeDir (const char *includeDir)
+    {
+        config->setIncludeDir(includeDir);
+    }
+
+    const char * getIncludeDir ()
+    {
+        return config->getIncludeDir();
+    }
+
 private:
     Config * config;
 };
@@ -238,6 +278,14 @@ BOOST_PYTHON_MODULE ( pylibconfig )
         .def("setValue", &pyConfig::setValue_long )
         .def("setValue", &pyConfig::setValue_int )
         .def("setValue", &pyConfig::setValue_str )
-        .def("appendToList", &pyConfig::appendToList )
+        .def("appendBooleanToList", &pyConfig::appendBooleanToList )
+        .def("appendBigIntegerToList", &pyConfig::appendBigIntegerToList )
+        .def("appendIntegerToList", &pyConfig::appendIntegerToList )
+        .def("appendFloatToList", &pyConfig::appendFloatToList )
+        .def("appendStringToList", &pyConfig::appendStringToList )
+        .def("appendArrayToList", &pyConfig::appendArrayToList )
+        .def("appendGroupToList", &pyConfig::appendGroupToList )
+        .def("setIncludeDir", &pyConfig::setIncludeDir )
+        .def("getIncludeDir", &pyConfig::getIncludeDir )
     ;
 }

[cnangel]

why not use appendToList?

[motoshkov]

appendToList adds String type only.
If I want to add float, integer or group - I have no way to do so with
python-libconfig.
So I though that as simplest (but not the correct probably) solution is to
add "appendToList" for each Type

On 25 January 2016 at 03:31, Cnangel notifications@github.com wrote:

why not use appendToList?

—
Reply to this email directly or view it on GitHub
#12 (comment)
.

[cnangel]

if you want patch all diff , please pull requests.